fix(cli): macOS 12 users get Chrome 150 automatically and can render - #4185
Open
miguel-heygen wants to merge 1 commit into
Open
miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
miguel-heygen
force-pushed
the
fix/cli-macos12-managed-chrome-refusal
branch
from
September 19, 2026 18:55
6cd5728 to
ee17024
Compare
| [ | ||
| "--eval", | ||
| `Object.defineProperty(process, "platform", { value: ${JSON.stringify(hostPlatform)} }); Object.defineProperty(process, "arch", { value: ${JSON.stringify(hostArch)} }); import(${JSON.stringify(moduleUrl)}).then(({ resolveHeadlessShellPath }) => process.stdout.write(resolveHeadlessShellPath({}) ?? ""))`, | ||
| `Object.defineProperty(process, "platform", { value: ${JSON.stringify(hostPlatform)} }); Object.defineProperty(process, "arch", { value: ${JSON.stringify(hostArch)} }); const os = require("node:os"); os.release = () => "24.0.0"; require("node:module").syncBuiltinESMExports(); import(${JSON.stringify(moduleUrl)}).then(({ resolveHeadlessShellPath }) => process.stdout.write(resolveHeadlessShellPath({}) ?? ""))`, |
| [ | ||
| "--eval", | ||
| `Object.defineProperty(process, "platform", { value: ${JSON.stringify(hostPlatform)} }); Object.defineProperty(process, "arch", { value: ${JSON.stringify(hostArch)} }); import(${JSON.stringify(moduleUrl)}).then(({ resolveHeadlessShellPath }) => process.stdout.write(resolveHeadlessShellPath({}) ?? ""))`, | ||
| `Object.defineProperty(process, "platform", { value: ${JSON.stringify(hostPlatform)} }); Object.defineProperty(process, "arch", { value: ${JSON.stringify(hostArch)} }); const os = require("node:os"); os.release = () => "24.0.0"; require("node:module").syncBuiltinESMExports(); import(${JSON.stringify(moduleUrl)}).then(({ resolveHeadlessShellPath }) => process.stdout.write(resolveHeadlessShellPath({}) ?? ""))`, |
| "bun", | ||
| [ | ||
| "--eval", | ||
| `Object.defineProperty(process, "platform", { value: "darwin" }); Object.defineProperty(process, "arch", { value: "x64" }); const os = require("node:os"); os.release = () => "21.6.0"; require("node:module").syncBuiltinESMExports(); import(${JSON.stringify(moduleUrl)}).then(({ resolveHeadlessShellPath }) => process.stdout.write(resolveHeadlessShellPath({}) ?? ""))`, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chromeMajorCeiling()(a tiny engine module, also exported as a subpath so the CLI does not load the whole engine). The CLI's managed-build choice (cache match, download, puppeteer-cache lookup) and the engine's own cache lookup both go through it, so render, validate, layout, capture, Studio and direct engine use agree.HYPERFRAMES_BROWSER_PATHandPRODUCER_HEADLESS_SHELL_PATHstill win. A newer cached build is ignored on macOS 12; hosts on macOS 13+ are unchanged.--experimental-fast-capture=truestill opts in.drawElementImageis a function with--enable-features=CanvasDrawElement, undefined without it).Not covered, said plainly
vite.browser.ts) and the HDR headed capture (hdrCapture.ts) scan the puppeteer cache for the newest build with no ceiling. Small follow-up, same helper.os.release()that does not parse falls back to the current pin (old behaviour).Test plan
old_chrome.tsc --noEmitclean for engine, producer, cli; package-subpath contract check passes; clisrc/browser+src/commands(1143 tests) and engine config/browserManager/ceiling (183 tests) pass on a Linux box.Review
Independent read-only review found one blocking gap (fast capture on 150, fixed here), the barrel import cost (fixed with the subpath), the stale crash hint (fixed), and the two unresolved callers above (noted). The review ran on the head before those fixes; the fixes carry their own tests and mutation checks.