Fix session and storage reliability - #106
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/private/tmpworkspaces and the macOS per-user temporary rootWhy
The app could show stale work state, miss generic build/test temporary roots, under-report Simulator storage, and emit storage alerts under the wrong application identity. In particular,
modore://storage/recoverytreated any previously loaded report as current and skipped the scan, while temporary workspaces could consume tens of gigabytes yet remain visible only as an unactionable aggregate. These changes make recovery collect current evidence and turn an exact, idle workspace into an owner-approved recovery item without granting deletion semantics to an entire temporary root.Verification
PYTHONDONTWRITEBYTECODE=1 python3 -I -B -m pytest tests/test_macos_storage_protection.py tests/test_macos_cleanup.py tests/test_report.py -q— 174 passedswift test --package-path macos/Modore— 485 passedPYTHONDONTWRITEBYTECODE=1 python3 -I -B -m pytest tests/test_fileaccess.py tests/test_scree.py tests/test_macos_storage_protection.py -q— 544 passedbash -n scripts/cleanup.sh scripts/modules/macos/storage.shandgit diff --checkpassedDARWIN_USER_TEMP_DIRastransient_workspace0bcc647enabled=true,loaded=true,loadedDefinitionCurrent=true