Repository navigation
test: give the remarkStripMdxJs warm-up hook headroom under worker contention - #271
Merged
Merged
Conversation
…ntention The beforeAll that loads the MDX toolchain ran with a 30s hookTimeout. Alone it takes ~8s, but with every test file in its own isolated worker on a saturated host it exceeded 30s and failed the whole file (and with it the coverage report). Raise it to 120s: the hook guards against a hang, not a slow box. Closes #269 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
src/__tests__/remarkStripMdxJs.test.tswarms up the MDX toolchain in abeforeAllwith a 30shookTimeout. Alone the file takes ~8–9s, but vitest spawns one isolated worker per test file (94 files), and on a loaded host the warm-up exceeded 30s and failed the whole file — 3/3 local full-suite runs ata968e69— which also suppresses thecoverage/report.This raises the warm-up timeout to 120s. The hook guards against a hang, not a slow box, so the headroom is free on a healthy run.
Verified:
npx vitest run --coverage→ 94 files / 935 tests pass at default parallelism on a host with loadavg 48 (previously failed at loadavg 17).Closes #269
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88