Repository navigation
feat(sync): sync Hive ADRs 0018–0024 to the docs site - #359
hivecommons-hive[bot] wants to merge 2 commits into
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
hivecommons-hive
Bot
added
author/hive
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
This will not build as written: two of the seven new entries name files that do not exist on the branch the sync reads from.
scripts/sync-hive-docs.ts:15 resolves branch = HIVE_DOCS_REF || "v5", and :17 fetches from raw.githubusercontent.com/hivecommons/hive/v5/src/docs. The "Lint and build" job fails at exactly this point (sync-hive-docs.ts:223, 404 on adr/0020-external-work-source-boundary.md), which also takes down the Netlify preview and the internal-links check.
What I verified in hivecommons/hive (contents/src/docs/adr):
| entry in this PR | on v5 |
on v6 |
|---|---|---|
0018-dashboard-design-tokens.md |
✅ | ✅ |
0019-escalation-over-stalling.md |
✅ | ✅ |
0020-external-work-source-boundary.md |
❌ (v5 has 0020-spek-continuous-convergence.md) |
✅ |
0021-planning-engine-boundary.md |
❌ (no 0021 on v5) | ✅ |
0022, 0023, 0024-provider-credential-lifecycle.md |
✅ | ✅ |
So the list in #358 was taken from v6, not v5, despite the issue saying it was verified against origin/v5. The v5 src/docs/adr/README.md:56-60 links only 0018, 0019, 0022, 0023, 0024 — those five are the ones the synced readme currently rewrites to GitHub links, and they are the real fix for #358.
Suggested change (keeps the fix on-branch and green):
- drop the
0020-external-work-source-boundary.mdand0021-planning-engine-boundary.mdentries fromscripts/sync-hive-docs.ts:79-80; - optionally add
adr/0020-spek-continuous-convergence.md(exists on v5, though the v5 README does not link it, so it is not needed for #358); - adjust the changelog fragment wording ("0018–0024" → the actual set).
The test tweak in sync-hive-docs.main.test.ts:68 (wait for 0024-provider-credential-lifecycle.md) is fine either way since 0024 does exist on v5. When the sync later moves to v6 the two v6-only ADRs can be added then.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
… 0021 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
hivecommons-hive
Bot
added
stage/050-review-pending
|
Closing in favour of #360 by @Karibhou: the two diffs are now byte-identical (same six ADRs 0018, 0019, 0020-spek-continuous-convergence, 0022, 0023, 0024 — verified against the hive 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Closes #358
Adds the seven ADRs that landed on hivecommons/hive v5 after 0017 to the sync list in scripts/sync-hive-docs.ts so they are hosted at /docs/hive/adr/… like 0001–0017 instead of the synced ADR readme linking out to GitHub for them. Includes the changelog.d fragment.
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88