Repository navigation
test: gate CNAME against SITE_ORIGIN, canonical URLs and the github.io fallback host - #131
Merged
Merged
Conversation
…o fallback host Add scripts/site-origin.test.mjs, a static gate reading CNAME as the single source of truth for the Pages host. It validates CNAME is one bare lowercase DNS host, requires every SITE_ORIGIN constant in sibling gates, every sitemap.xml <loc>, the robots.txt Sitemap: URL and every canonical page's <link rel=canonical>/og:url to be at https://<CNAME>, and fails when any committed page or text asset links the hivecommons.github.io fallback host. Each rule has a fixture self-test. Picked up by the existing node --test scripts/*.test.mjs CI step; README Checks section documents it. Closes #130 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
scripts/site-origin.test.mjs, a static gate that readsCNAME— the one file GitHub Pages actually consults for the serving host — and ties everything else to it:CNAMEmust be a single bare lowercase DNS host (no scheme, path, port, trailing dot, extra line, CRLF or padding).SITE_ORIGINconstant hardcoded in sibling gates (page-meta,page-scripts,availability-probes), everysitemap.xml<loc>, therobots.txtSitemap:URL and every canonical page's<link rel="canonical">/og:urlmust have originhttps://<CNAME>..html/.css/.txt/.xml/.svg/.jsonmay link thehttps://hivecommons.github.iofallback host (repository URLs ongithub.comare fine).Each rule has a fixture self-test; zero dependencies. Picked up automatically by the existing
node --test scripts/*.test.mjsCI step — no workflow change. README## Checksdocuments the gate.Verified locally at
7858cb9: full suite 302 → 314 pass; mutation checks fail as intended (www.CNAME → 3 failures, two-line CNAME → 4,SITE_ORIGINpointed atgithub.ioin one gate → 1 failure naming the file).Closes #130
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88