Repository navigation
test: gate links.yml step list, script naming and README Checks against scripts/ - #135
Merged
Merged
Conversation
…st scripts/ links.yml runs node gates through one glob but wires each shell gate and self-test by hand, so a new check-*.sh or *.test.sh can be committed, documented and never run in CI. Add scripts/ci-wiring.test.mjs: every scripts/*.sh gate and *.test.sh self-test must be invoked by an unconditional job, every gate must have a self-test, the node glob step must exist unconditionally, no .mjs importing node:test may sit outside the glob's name, the workflow must run on pull_request and push to main, shell scripts must be executable, and README Checks must name every gate. Fixture self-tests for each rule; README entry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
hive/awaiting-ci: all required checks green on the current head; only 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
scripts/ci-wiring.test.mjs, a static gate keeping.github/workflows/links.yml, the contents ofscripts/and README## Checksin step. The node gates run through one glob, but the shell gates and their self-tests are each wired by a hand-writtenrun:step, and nothing compared that list to the directory:links.ymljobs, theirrun:commands (inline and|block scalars) andif:conditions.scripts/*.shgate and everyscripts/*.test.shself-test must be invoked, as a whole path token, by at least one unconditional job; every gate must have a sibling.test.sh.node --test scripts/*.test.mjsstep must exist and be unconditional; ascripts/*.mjsthat importsnode:testbut is not named*.test.mjsis reported (the glob would skip it), as is a*.test.mjsthat does not importnode:test.on:must includepull_requestandpushtomain(what README promises).scripts/*.shandmake-redirects.shmust be executable.## Checksmust name every gate and self-test.Each rule has a fixture self-test; zero dependencies. Picked up automatically by the existing glob step — no workflow change. README
## Checksdocuments the gate (entry appended aftercheck-redirects.test.sh, so it does not overlap the bullet #133 inserts).Verified locally at
7d6d8e1: full suite 314 → 327 pass. Mutation checks against scratch copies: removing theSelf-test check-redirectsstep → the live gate fails namingscripts/check-redirects.test.sh; addingscripts/helper.mjsimportingnode:test→ reported as outside the glob; every pre-existing gate stays green on both mutations.When this gate fails because a step is missing from
links.yml, the fix is a workflow edit that needs a human or an ISSUES_PRS_MERGE agent — the quality agent cannot push.github/workflows/**. Every other failure mode it reports is fixable in a normal PR.Closes #134
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88