Repository navigation
Resolve builtin results and abortive expression flow - #598
Merged
Merged
Conversation
Builtin applications lacked result shapes, while exhaustive splits and loops could contribute spurious normal values. Share operand-dependent builtin result rules between resolution and IR, track ordered branch fallthrough and loop repetition, and avoid lowering unreachable continuations. Keep Wasm builtin results conservative. Extract B02 (E09 and E16) from PR hkust-taco#575. Add focused JS and explicitly typed Wasm regressions, retain narrowing-cast coverage with Num inputs and a fractional SCC result, and include the regenerated goldens and builtin approximation documentation. Validation: Metals compilation, ctest and cwtest, focused diff tests, and hkmc2AllTests/test (1,157 tests). Confirmed the builtin-call and abortive-control-flow regressions fail on the extraction base. Reviewed the complete diff and checked whitespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[GPT-6 Astra]
Builtin applications lacked result shapes, while exhaustive splits and loops could contribute spurious normal values. Share operand-dependent builtin result rules between resolution and IR, track ordered branch fallthrough and loop repetition, and avoid lowering unreachable continuations. Keep Wasm builtin results conservative.
Extract B02 (E09 and E16) from PR #575. Add focused JS and explicitly typed Wasm regressions, retain narrowing-cast coverage with Num inputs and a fractional SCC result, and include the regenerated goldens and builtin approximation documentation.
Validation: Metals compilation, ctest and cwtest, focused diff tests, and hkmc2AllTests/test (1,157 tests). Confirmed the builtin-call and abortive-control-flow regressions fail on the extraction base. Reviewed the complete diff and checked whitespace.