Repository navigation
Separate async and generator body results from callable wrappers - #599
Merged
LPTK merged 10 commits intoOct 30, 2026
Merged
Conversation
Expose Promise and Iterator in callable signatures while preserving the declared body payload for explicit and implicit returns. Keep completed payload metadata in the defining compilation unit and rename it when cloning source bodies. Generator resolution carries its pending wrapper through curried and generic callable interfaces. Cover typed Promise call boundaries, generator overrides and currying, nominal methods, cloned nominal payloads, and imported patterns. Preserve legacy resolution and leave shape-based symbol inference for the remaining PR. Validation: Metals compilation; ctest and cwtest; focused async, generator, and cloning suites; hkmc2AllTests/test (1,158 tests). Reviewed the complete diff and regenerated golden output.
Contributor
Author
|
Glad that we've split #575 up into many smaller chunks, as this has already allowed me to detect a few very smelly designs, which are being fixed (here and in follow-up PRs). |
LPTK
pushed a commit
to LPTK/mlscript
that referenced
this pull request
Oct 30, 2026
Integrate hkust-taco#599 and hkust-taco#600 while preserving inferred erasure and representation-changing deforestation. Reconcile shared function signatures with retyped and refreshed bindings, retain inferred wrapper regressions, and adapt the cast-comment fixtures to inference and cast elimination. Update the extraction plan and include regenerated golden outputs. Validation: Metals hkmc2JVM compilation and hkmc2AllTests/test (1,172 tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[GPT-6 Astra]
Expose Promise and Iterator in callable signatures while preserving the declared body payload for explicit and implicit returns. Keep completed payload metadata in the defining compilation unit and rename it when cloning source bodies. Generator resolution carries its pending wrapper through curried and generic callable interfaces.
Cover typed Promise call boundaries, generator overrides and currying, nominal methods, cloned nominal payloads, and imported patterns. Preserve legacy resolution and leave shape-based symbol inference for the remaining PR.
Validation: Metals compilation; ctest and cwtest; focused async, generator, and cloning suites; hkmc2AllTests/test (1,158 tests). Reviewed the complete diff and regenerated golden output.