Repository navigation
Locate representation conversion diagnostics at their source - #601
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Representation-conversion errors for implicit returns and synthetic constructor fields can omit their source span, and Wasm conversions discard locations available to their callers. Preserve the value, field-name, or enclosing-operation location when reporting these errors.
This extracts only E08 from #575: the diagnostic-location part of B05. The implementation is 19 added and 13 removed lines across two Scala files. Existing fixtures cover return and argument conversions; two small JS/Wasm regressions cover the constructor-field fallback. The remaining changes are regenerated diagnostic spans.
Validation: Metals compilation,
ctest,cwtest, focused diff tests, andhkmc2AllTests/test(1,165 tests passed). Compared the regressions againsthkmc2to confirm the previously missing locations, reviewed the complete diff, and checked that existing test inputs and generated code remain unchanged.