Repository navigation
Effect Handlers Benchmarks - #629
Merged
Merged
Conversation
Contributor
|
@CAG2Mark pls update the branch and use new resolution everywhere. |
Contributor
|
Isn't it better to match the bug of product_early? |
Contributor
Author
I'm mostly indifferent. But if you look at the code, it should make no difference in the actual benchmark anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
product_earlybenchmark which I have fixed, though it should not affect the running time at all.:exitto the top of the other benchmarks, which I think should be the default. They can be uncommented when needed.I also noticed that the LazySpreads benchmark is broken. Might be good to take a look at some point.