metrics: count invalid EVENTs, document what nostr_events_total counts (#255) - #267
Open
sunmoonron wants to merge 1 commit into
Open
sunmoonron wants to merge 1 commit into
sunmoonron wants to merge 1 commit into
Conversation
…tr_events_total counts README said nostr_events_total counts events processed while the metric's HELP text and RelayWriter say persisted; the README now matches the code (issue hoytech#255). Events that fail validation in the ingester were not counted anywhere; they now increment a new strfry_invalid_events_total counter, leaving strfry_write_rejected_total's meaning (rejected during write) as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small things from the discussion in #255:
nostr_events_totalas "events processed", while the metric's HELP text andRelayWriter.cppcount only events persisted to the DB. The README now says persisted and points at the rejected and duplicate counters, so the two sources no longer contradict each other.strfry_invalid_events_totalcounter. I keptstrfry_write_rejected_totalmeaning what its HELP text says (rejected during the write path) rather than folding invalid messages into it, so nobody's dashboards change meaning.Happy to fold the new counter into
strfry_write_rejected_totalinstead if you would rather have one number.