Repository navigation
Fix Discord deeplink forwarding to a running FrameRelay instance - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord launch links can fail when FrameRelay is already open, forcing users to close the app and launch it again. The activation pipe creates auto-flushing UTF-8 writers on both ends before reading, which can block while flushing the preamble.
Read the request before creating the server writer and use UTF-8 without a preamble on both ends. Keep BOM detection enabled for incoming messages. Add regression coverage for consecutive share and watch activations over a unique pipe, so tests can run while the installed application is open.
Validation: all 5 focused activation coordinator and instance policy tests passed. The original forwarding test hung before the fix. Build and git diff --check passed. The installed application and real Discord flow have not been updated or validated.
Test command: