Repository navigation
Fix H.264 keyframe parameter set ordering for Activity playback - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The Activity diagnostics showed WebCodecs receiving an access unit with
AUD, SPS, PPS, IDR, while the desktop publisher prepended its cached SPS/PPS unconditionally. That producedSPS, PPS, AUD, SPS, PPS, IDR, duplicating parameter sets and placing the access-unit delimiter after them.The publisher now preserves keyframes that already contain SPS and PPS, and injects only whichever parameter sets are missing. This retains the AUD-first ordering while keeping recovery keyframes self-contained.
Validation
dotnet test tests/SonicDesktopRelay.Media.Tests/SonicDesktopRelay.Media.Tests.csproj --no-restore— 134 passed.