Repository navigation
chore(solid_queue): allow sentry-ruby 6.x above 6.4.1 (HUN-23754) - #4
Closed
alexey-hunter-io wants to merge 1 commit into
Closed
alexey-hunter-io wants to merge 1 commit into
alexey-hunter-io wants to merge 1 commit into
Conversation
sentry-ruby 6.7.0 adds `config.hub_isolation_level = :fiber`, which the Hunter app needs for Solid Queue fiber workers. The `~> 6.4.1` pin kept the app on 6.4.x. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TM8VzjEjcNfNvmnpKdfXKn
Author
|
No longer needed: hunter-io/hunter#17147 dropped the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentry-solid_queuepinssentry-ruby ~> 6.4.1, which keeps the Hunter app on 6.4.x. The app needs sentry-ruby 6.7.0 forconfig.hub_isolation_level = :fiber, so that Solid Queue fiber workers stop sharing one Sentry hub across concurrent jobs (HUN-23754).This relaxes the constraint to
>= 6.4.1, < 7. No code changes.Checked in the Hunter app against sentry-ruby and sentry-rails 6.7.0: jobs run through this gem's
perform_nowpath as concurrent fibers keep their own scope, and sentry-rails' new Active Job Solid Queue support stays off because this gem still registers the adapter inskippable_job_adapters.Please merge with a merge commit: the app's
Gemfile.lockpins this branch's commit (7e9662e).🤖 Generated with Claude Code
https://claude.ai/code/session_01TM8VzjEjcNfNvmnpKdfXKn