DALib migration - #337
Merged
Merged
DALib migration#337
Conversation
Also removes docs/ncalc-integer-division.md. That note claimed NCalc truncates integer division; measured against the pinned NCalcSync 6.3.1 it does not, and the regen-returns-0 symptom it described came from a misplaced paren in the xml package's default formula.
…lean up duplicates
Member
Author
|
intermittent status removal failure which I already have a ticket to fix - merging |
|
Great job Justin, Keep it up! |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove all crypto / codec / framing / etc and use new DALib networking support.
This PR removes all custom networking from Hybrasyl and uses DALib globally. Now that Brigid exists, this means we use the same networking library in both places.
Also fixes some bugs:
HS-1505: certain stat bonuses resulted in additive rather than multiplicative effects
HS-1506: fix overflow / div by zero / rounding in formula calc
HS-1507: drop ServiceModel.Primitives & fix advisory (unused anyway)
HS-1566: shields should be able to be attacked
HS-1577: enforce correlation between 0x39 and merchant handling types
HS-1600: status dictionary needs to be concurrent