Repository navigation
docs(collections): explain connector cleanup on deletion - #342
adityamishra-hydradb wants to merge 2 commits into
Conversation
Signed-off-by: adityamishra-hydradb <321510987+adityamishra-hydradb@users.noreply.github.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
✅ Mintlify HygieneNo issues found. |
|
@greptileai review |
|
/devin review |
✅ OpenHack SummarySecurity review of docs(collections): explain connector cleanup on deletion. 1 changed file; 0 findings at or above the low reporting threshold. Confidence Score: 5/5No reportable security findings were detected in this scan. Security merge-readiness rubric: 1 = critical, 2 = high, 3 = medium, 4 = low, 5 = no reportable findings. This score reflects scan findings, not a guarantee of correctness or complete coverage. Files Needing Attention: None Important Files Changed
Last reviewed commit: c35adb8 · View review on OpenHack
|
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
[Low impact] The documentation appears safe to merge after the application change reaches production, as required by the PR. SummaryThe delete-collection reference now explains three connector side effects:
The PR explicitly requires the application change to reach production before these docs merge. No actionable issues were found. Reviews (2) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile |
|
@greptileai review |
|
/devin review |
…eng-3301-collection-delete-stops-connectors-docs-dco-v2 Signed-off-by: adityamishra-hydradb <321510987+adityamishra-hydradb@users.noreply.github.com>
4afa938 to
c35adb8
Compare
|
@greptileai review |
|
/devin review |
For humans
The delete-collection reference now states that deletion removes dedicated connectors, disables matching defaults, and removes matching resources from mixed connectors.
Linear: https://linear.app/hydradb/issue/ENG-3301
Merge this PR only after the application change reaches production.
This PR replaces #340 because force-push is prohibited and its latest commit lacked DCO sign-off.
End-to-end proof
A disposable local A/B run verified the documented behavior. On
origin/staging, deletingsalesleft the connector route active, and the next sync recreatedsales. On the feature branch, cleanup removedC123 → sales, retainedC456 → ops, and the next sync leftsalesabsent.Both deletes returned HTTP 200. Both sync requests returned HTTP 202 and completed in Temporal. No staging or production service was accessed.
Full proof, commands, and before/after screenshots: https://github.com/hydra-db/dashboard-2.0/pull/766#local-ab-sync-after-collection-deletion
Testing
Passed:
verify:agents-endpointschecked 54 endpoint mentions. DCO, Mintlify validation, hygiene, deployment, Greptile, and OpenHack checks passed.No staging or production service was accessed.
Decisions taken without review
Risk Assessment
1/10 — documentation-only.
The endpoint schema did not change. The new sentence documents the verified cleanup semantics. Automated documentation validation passed.
Merge order
Session Details
(aside)to your comment to have me ignore it.Need help on this PR? Tag
@codesmith-botwith what you need.