Skip to content

[node-maintenance-repair/4.1] Report conversation outcomes and release completed requests - #47

Open
omry wants to merge 1 commit into
comment-repairfrom
pr47
Open

omry wants to merge 1 commit into
comment-repairfrom
pr47

Conversation

@omry

@omry omry commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Report canonical workflow outcomes in the existing PR conversation reply and request Check, then release only the verified completed request lock. Keep Request accepted and a workflow-page link until completion supplies the final result and exact run URL.

Only the winning admission writes pending output before dispatch. Replays and PR refreshes do not repaint request status, and exposed idle controls are never PATCHed. Reuse existing D1 outcome fields, retain ambiguous active requests, and clean up only terminal records older than 90 days.

Validation: 224 Worker tests; actual local Workers/D1 success, failure, cancellation and retained-lock recovery; pinned Wrangler dry-run; 1294 Python tests; lint, format, types and changed-line whitespace. GitHub responses in local runtime tests are intercepted fixtures. Real dependency repair and production report integration remain later slices.


…e completed requests

Report canonical workflow outcomes in the existing PR conversation reply and request Check, then release only the verified completed request lock. Keep Request accepted and a workflow-page link until completion supplies the final result and exact run URL.

Only the winning admission writes pending output before dispatch. Replays and PR refreshes do not repaint request status, and exposed idle controls are never PATCHed. Reuse existing D1 outcome fields, retain ambiguous active requests, and clean up only terminal records older than 90 days.

Validation: 224 Worker tests; actual local Workers/D1 success, failure, cancellation and retained-lock recovery; pinned Wrangler dry-run; 1294 Python tests; lint, format, types and changed-line whitespace. GitHub responses in local runtime tests are intercepted fixtures. Real dependency repair and production report integration remain later slices.
@omry
omry changed the base branch from main to comment-repair October 24, 2026 18:06
@omry
omry added this pull request to stack #44 October 24, 2026 18:07
@omry

omry commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:5f73242539e5ece763109e8a7a76c3444befa039e9e6bcd5e62dbe4eb297a26c",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:5f73242539e5ece763109e8a7a76c3444befa039e9e6bcd5e62dbe4eb297a26c",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "repair-app",
          "run_id": 120946862327
        },
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 120946862620
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 120946862566
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 120946862583
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 120946862700
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 120946862611
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 120946862568
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 120946862721
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "operation_identity": "sha256:0d0b6fd73bc80fe4c7291197baf7caf96fbc4d8969e58f4308c4b316b0e469a8",
      "review_request": {
        "body_digest": "sha256:bc07c75165a51a83eb8a52c76a405af314a0c94aa21bdc6960fd3f4caff0467a",
        "id": 6387824962
      },
      "review_result": {
        "body_digest": "sha256:7cb75e8a13e56581eeac7089f4629c7e744033c496a1b48eb1276c27db2db3ab",
        "id": 6387950883
      }
    },
    "evidence_fingerprint": "sha256:eb4f279b2d5a9ca000d552855d14727dc7e2112800795f9cc40bdd907246993b",
    "head_sha": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
    "operation_identity": "sha256:0d0b6fd73bc80fe4c7291197baf7caf96fbc4d8969e58f4308c4b316b0e469a8",
    "review_request_id": 6387824962,
    "review_result_id": 6387950883,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:5f73242539e5ece763109e8a7a76c3444befa039e9e6bcd5e62dbe4eb297a26c",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "repair-app",
      "run_id": 120946862327
    },
    {
      "conclusion": "SUCCESS",
      "name": "test",
      "run_id": 120946862620
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, npm, 11.9.0)",
      "run_id": 120946862566
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, pnpm, 11.20.0)",
      "run_id": 120946862583
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, pnpm, 11.21.0)",
      "run_id": 120946862700
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, npm, 11.9.0)",
      "run_id": 120946862611
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, pnpm, 11.20.0)",
      "run_id": 120946862568
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, pnpm, 11.21.0)",
      "run_id": 120946862721
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "repair-app",
          "run_id": 120946862327,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40119207579/job/120946862327"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 120946862620,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40119207579/job/120946862620"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 120946862566,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40119207579/job/120946862566"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 120946862583,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40119207579/job/120946862583"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 120946862700,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40119207579/job/120946862700"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 120946862611,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40119207579/job/120946862611"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 120946862568,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40119207579/job/120946862568"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 120946862721,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/40119207579/job/120946862721"
        }
      ],
      "head_sha": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
      "id": "sha256:3472802ee1e0f1a319d13d3964c4dbef1ed3ab4232f77a7d486135d33325baf2",
      "required_checks": [
        "repair-app",
        "test",
        "toolchain (22, npm, 11.9.0)",
        "toolchain (22, pnpm, 11.20.0)",
        "toolchain (22, pnpm, 11.21.0)",
        "toolchain (24, npm, 11.9.0)",
        "toolchain (24, pnpm, 11.20.0)",
        "toolchain (24, pnpm, 11.21.0)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [],
  "pr": {
    "base_ref": "comment-repair",
    "base_sha": "475355edb87693bb970d28d6674c295df476684f",
    "body_digest": "sha256:5eee4d4f72ace842ee8a7e6b3342da6dbc74bcedb6ee0ca7c792fe539f19e4a7",
    "body_identity_version": 2,
    "diff_digest": "sha256:9aac7920189cd23ea5e6b5078593bf2f8a2266ee4a3c31aa8d50eab06ed0c07b",
    "head_ref": "pr47",
    "head_sha": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
    "pr": 47,
    "repository": "hydra-ecosystem/github-actions",
    "scope_authority": [],
    "title_digest": "sha256:e56c665fbba24d6523dcb27ffd61ea703ba8fa6ed8f2eddb781930763d1ae8d6"
  },
  "record_version": 6,
  "review_observations": [
    {
      "base_ref": "comment-repair",
      "base_sha": "475355edb87693bb970d28d6674c295df476684f",
      "evidence_digest": "sha256:07cb209de35aa7aa55fda23a7c9cde345db02355ba683c37caa0461e78a5cfb0",
      "head_sha": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
      "id": "sha256:c499074a6f26ae57dde7ae9b4621d9d8f994672a8393fb5dadabbcac24e24575",
      "poll": {
        "completed_at": "2026-10-24T18:20:40.661Z",
        "elapsed_seconds": 185.004,
        "observations": 19,
        "started_at": "2026-10-24T18:17:24.787Z"
      },
      "request_comment_id": 6387824962,
      "status": "timeout"
    }
  ],
  "review_requests": [
    {
      "base_established_at": "2026-10-24T18:06:52Z",
      "base_ref": "comment-repair",
      "base_sha": "475355edb87693bb970d28d6674c295df476684f",
      "body_digest": "sha256:bc07c75165a51a83eb8a52c76a405af314a0c94aa21bdc6960fd3f4caff0467a",
      "created_at": "2026-10-24T18:17:55Z",
      "head_sha": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
      "id": 6387824962,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "comment-repair",
      "base_sha": "475355edb87693bb970d28d6674c295df476684f",
      "body_digest": "sha256:7cb75e8a13e56581eeac7089f4629c7e744033c496a1b48eb1276c27db2db3ab",
      "commit_id": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
      "id": 6387950883,
      "inline_message_ids": [],
      "request_comment_id": 6387824962,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-10-24T18:30:10Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:5f73242539e5ece763109e8a7a76c3444befa039e9e6bcd5e62dbe4eb297a26c",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:9aac7920189cd23ea5e6b5078593bf2f8a2266ee4a3c31aa8d50eab06ed0c07b",
      "finding_ids": [],
      "invariants": [],
      "outcome": "timeout",
      "proposed_fix_paths": [],
      "resulting_head": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
      "review_observation_id": "sha256:c499074a6f26ae57dde7ae9b4621d9d8f994672a8393fb5dadabbcac24e24575",
      "review_request_id": 6387824962,
      "review_result_id": null,
      "reviewed_head": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
      "root_cause": null,
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    },
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:9aac7920189cd23ea5e6b5078593bf2f8a2266ee4a3c31aa8d50eab06ed0c07b",
      "finding_ids": [],
      "invariants": [],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
      "review_observation_id": null,
      "review_request_id": 6387824962,
      "review_result_id": 6387950883,
      "reviewed_head": "03065f8e1aeec8ef02f2aa9eca2a17202e272517",
      "root_cause": null,
      "round": 2,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry
omry marked this pull request as ready for review October 24, 2026 18:14
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T18:30:11.912455Z 03065f8 Manual request
🔒 Security Review ✅ Completed 2026-10-24T18:17:05.675494Z 03065f8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omry

omry commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Exact head: 03065f8

1 similar comment
@omry

omry commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Exact head: 03065f8

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 03065f8e1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant