Repository navigation
Conversation
Owner
|
Thanks a lot for this, Enzo, and sorry for the slow turnaround. Your diagnosis was right: the dropdown is never empty because of the built-in None and Auto options, so the pending preset was dropped too early. The fix landed in #312, which takes the same approach (keep the selection pending until the instruction list has loaded) and also stops the preference auto-save from syncing the default value back to the server while the preset is still pending, since that is what spread the loss to other devices. As #312 covers this, I'm closing this one. Thanks again for digging into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284.
The server-synced preference path could apply a saved custom instruction before
loadCustomInstructions()populated the dropdown. Since the template already contains its default options, the pending selection was treated as missing and discarded.Keep the selection pending until the
customInstructionsLoadedevent fires. If the preset exists, restore it; if the list has finished loading and the preset is absent, log and clear the stale value.Verification:
translation_api.pyand confirmed the homepage returned HTTP 200.node --check src/web/static/js/core/settings-manager.jsgit diff --check