Repository navigation
fix: read a missing pgrep or ip as VPN down - #73
Merged
Merged
Conversation
_check_openvpn and _check_wireguard let FileNotFoundError escape when the host lacks pgrep or iproute2. The /metrics scrape calls both, so the whole scrape failed instead of reporting zero peers. Renovate PRs run on arc-native-4cpu, which has neither binary, and failed test_wireguard_mode_scrapes_without_a_running_interface on that. Both checks now return False when their tool is missing. Liveness is unchanged: an exception and False both fail the probe.
Contributor
|
Released in v2.1.19 -- https://github.com/hyperi-io/culvert/releases/tag/v2.1.19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both open Renovate PRs (#71 ruff, #72 watchtower) fail one unit test, and neither bump is the cause. Renovate PRs route to arc-native-4cpu (org var GH_RUNNER_RENOVATE), which has no pgrep or ip. Human PRs run on ubuntu-latest, which has both, so main never saw it.
The defect is real though. _check_openvpn and _check_wireguard let FileNotFoundError escape, and update_metrics calls both on every /metrics scrape. scalo's observability server turns that into a 500 for the whole scrape, which is exactly what test_wireguard_mode_scrapes_without_a_running_interface says must not happen.
Done when this merges and #71/#72 go green on a rebase.