Repository navigation
fix: hunts-pause switches the engine's hunt-runner secret group off too - #10
Merged
Merged
Conversation
hunts-pause set huntRunner.enabled false and nothing else. dfe-extras then stops minting hunt-runner-clickhouse, but the engine Deployment still read it through a required secretKeyRef (DFE_CLICKHOUSE_HUNT_RUNNER_PASSWORD), so the engine pod sat in CreateContainerConfigError until a resume. hunts-pause now also sets secrets.hunt-runner.enabled false, hunts-resume sets both back so the engine adopts the runner's password again, and the governance README says a switch-off action carries its secret group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hunts-pause switched the hunt runner off and left the engine reading its password.
hunts-pause now also sets secrets.hunt-runner.enabled false. hunts-resume sets both back, otherwise the runner returns reading a password the engine no longer adopts. The governance README says why a switch-off action carries its secret group.
Checked by rendering the thin path (dfe-engine at its pinned chart digest, beside dfe-extras) with each overlay:
The render test is dfe-infra's test_governance_actions.py and runs against this tree.
Done when hunts-pause renders an engine pod with nothing left to wait on.