Repository navigation
fix(governance): lock the sizing keys a chart carries and explain the sizing directory - #3
Merged
Merged
Conversation
…rectory The upgrade classifier in dfe-infra refuses to move these fields without --migrate, and this policy is the write-side refusal. The README says what the resolver commits under sizing/ and why it is committed rather than re-derived.
storageModel was already held by storage-layout.yaml, and kafka.external.msk.* named the MSK bootstrap Job's settings rather than the broker type, which is an OpenTofu input along with the AZ count. The README now says what resolved.yaml actually records and where the resolver's other outputs go.
catinspace-au
changed the title
catinspace-au
marked this pull request as ready for review
October 2, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dfe-infra's sizing resolver refuses to move six fields without
--migrate: partition count, storage model, MSK broker type, KRaft controller mode, cloud and AZ count. This adds the engine-side refusal for the ones a chart key carries, and a README for what the resolver commits undersizing/.governance/policies/sizing-locks.yamlprotectskafka.sizing.*(the inputs the kafka chart derives the partition count from),kafka.controllerPool.enabledandcloud. Holders ofhelmvars:overridecan still make a deliberate exception.storage-layout.yaml, so it is not repeated here.kafka.external.msk.*: those keys are the MSK bootstrap Job's settings, not the broker type, and locking them would refuse a routine bump of its IAM auth jar.sizing/README.mdsays whatsizing/resolved.yamlrecords, why it is committed (dfe-ops upgrade plan --dialdiffs against it) and where the resolver's values fragment and tfvars go.The resolver side landed with dfe-infra #300, and dfe-infra's upgrades.md already points at this file.
Done when the engine refuses an API edit to any of the three keys from a caller without
helmvars:override.