Repository navigation
docs: record the Node 20 warning on upstream's docker actions as accepted - #139
Merged
Merged
Conversation
…pted docker-build.yml is upstream's file. Its seven docker action lines stay on upstream's setup-buildx-action@v3 and build-push-action@v6, which GitHub already runs on Node 24 with a warning and the builds pass. Bumping them in the fork would add seven conflicts the day upstream bumps them itself, so the catalogue entry for the file now says the warning is accepted until a sync brings that bump in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every docker-build run warns that docker/build-push-action@v6 and docker/setup-buildx-action@v3 target Node 20 and are being forced onto Node 24. The builds pass under 24 (run 38109012456, all three jobs green with the warning).
docker-build.yml is upstream's file and those seven uses: lines are still byte-identical to upstream, which is still on v6/v3. Bumping them here buys seven conflicts on the day upstream does its own bump, for a warning. So it stays put, and the catalogue entry for the file now says so, which is where the next person reading the warning will look.
Docs only, no fork surface added (fork-surface-check --base origin/main passes).