Repository navigation
fix: edit compound source matches and order the receiver's rule blocks - #601
Merged
Merged
Conversation
Taken from dfe-engine v1.22.69. It adds the match all, any and negate members, the CEL Fast when, the ingest rules and compatibility endpoints and the usage overview, with types regenerated.
The source form now builds a match from grouped conditions, all, any, none or not all, nested up to the engine's limit of 4, or takes one CEL Fast expression as when. A refused rule comes back marked where the engine stopped, and a single condition still opens and saves as the same three fields. A new Ingest rules page orders each field's rule blocks by keyboard, move buttons, a position menu or drag and drop. A save sends the order with the revision it was read at, and a list that changed under it is explained and reloaded. The same page binds the deployment's compatibility profiles, and a source can bind its own and name aliases. The dashboards page opens on a usage strip with each licensed metric at its highest in the last 7 days, and a tile the caller may not read says so.
Contributor
|
Released in v1.7.31 -- https://github.com/hyperi-io/dfe-ui/releases/tag/v1.7.31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The console side of the 2.2.1 rules work. dfe-engine v1.22.68 can store a source match as a tree of conditions or a CEL Fast expression, order the receiver's rule blocks and bind compatibility profiles. The console could do none of it until now.
Kay, the layout calls are all open to change.
ingestRules.spec.tscreates a compound and a CEL source, reorders, forces a 409 and opens the strip. It ran green twice against a local dfe-docker single-kafka stack on engine v1.22.69, without the e2e helpers.Screenshots from the headless review (taken locally, not attached):
Done when the three surfaces pass UX review and the unit and e2e runs are green on this branch.