-
-
Notifications
You must be signed in to change notification settings - Fork 0
policy: Bun is tier 1, Deno is being removed — correct local CLAUDE.md #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2bbcdeb
5d9e0fa
1678d14
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -49,7 +49,7 @@ The following files in `.machine_readable/` contain structured project metadata: | |||||||||||
| | Language/Tool | Use Case | Notes | | ||||||||||||
| |---------------|----------|-------| | ||||||||||||
| | **AffineScript** (`.affine`) | Primary application code | Affine types, dependent types, row polymorphism, extensible effects; compiles to Wasm | | ||||||||||||
| | **Deno** | Runtime & package management | Replaces Node/npm/bun | | ||||||||||||
| | **Bun** | JS runtime & package management (tier 1) | Default for all new work. Runs compiled ESM/JS directly — no bundler step. Uses an npm-compatible `package.json` plus `bun.lock` — both are expected, not anti-patterns. | | ||||||||||||
| | **Rust** | Performance-critical, systems, WASM | Preferred for CLI tools | | ||||||||||||
| | **Tauri 2.0+** | Mobile apps (iOS/Android) | Rust backend + web UI | | ||||||||||||
| | **Dioxus** | Mobile apps (native UI) | Pure Rust, React-like | | ||||||||||||
|
|
@@ -74,12 +74,13 @@ The following files in `.machine_readable/` contain structured project metadata: | |||||||||||
| | Banned | Replacement | | ||||||||||||
| |--------|-------------| | ||||||||||||
| | TypeScript | **AffineScript** | | ||||||||||||
| | ReScript | **AffineScript** | | ||||||||||||
| | (new files) | **AffineScript** (migration via #488) | | ||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ⚪ LOW RISK The acceptance criteria specify restoring the 'ReScript' terminology here to fix corruption from a previous purge. This line currently contains a blank space where the keyword was intended to be restored. |
||||||||||||
| | JavaScript (where the project has been meaningfully migrated to AffineScript) | **AffineScript** | | ||||||||||||
| | Node.js | Deno | | ||||||||||||
| | npm | Deno | | ||||||||||||
| | Bun | Deno | | ||||||||||||
| | pnpm/yarn | Deno | | ||||||||||||
| | Deno | Bun | | ||||||||||||
| | Node.js | Bun | | ||||||||||||
| | npm | Bun | | ||||||||||||
| | pnpm/yarn | Bun | | ||||||||||||
|
coderabbitai[bot] marked this conversation as resolved.
Comment on lines
+81
to
+83
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 MEDIUM RISK The policy change removes Deno as a Tier 1 tool, but it is missing from the BANNED table. To align with the goal of removing Deno and ensuring AI assistants avoid its use, it should be explicitly listed as banned for new code (e.g., mapping to Bun). Additionally, the runtime compatibility list at line 139 (marked 'Deno ✅') needs reconciliation with this removal. Suggested change for the BANNED table:
Suggested change
Comment on lines
+81
to
+83
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 MEDIUM RISK Suggestion: To complete the removal of Deno as a primary tool and provide clear guidance for the AI agent, add Deno to the BANNED table with Bun as the recommended replacement, mirroring the existing entries for Node.js and npm. |
||||||||||||
| | Go | Rust | | ||||||||||||
| | Python (general) | **AffineScript** / Rust / Julia | | ||||||||||||
| | Java/Kotlin | Rust / Tauri / Dioxus | | ||||||||||||
|
|
@@ -102,9 +103,9 @@ Both are FOSS with independent governance (no Big Tech). | |||||||||||
| ### Enforcement Rules | ||||||||||||
|
|
||||||||||||
| 1. **No new TypeScript files** - Write new code in AffineScript (closed exemptions table below covers the residual `.d.ts` / Deno-test cases). | ||||||||||||
| 2. **No new files** - As of 2026-05-25 policy refresh; AffineScript is the go-forward. Existing `.res` files stay until migrated via #488. | ||||||||||||
| 3. **No package.json for runtime deps** - Use deno.json imports. | ||||||||||||
| 4. **No node_modules in production** - Deno caches deps automatically. | ||||||||||||
| 2. **No new ReScript files** - As of 2026-05-25 policy refresh; AffineScript is the go-forward. Existing `.res` files stay until migrated via #488. | ||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 MEDIUM RISK The reference in Rule 1 (line 103) is incorrect. The mentioned exemptions (.d.ts and Deno-test) are in the Approved table at line 116, not the Closed table. Correcting this reference is critical for the AI agent to properly distinguish between active exemptions and resolved legacy items. |
||||||||||||
| 3. **Use `package.json` + `bun.lock` for JS runtime deps** - Bun is npm-compatible; a manifest is REQUIRED | ||||||||||||
| 4. **`bun install --production --frozen-lockfile` for production deps** - resolved from `package.json` and pinned via `bun.lock`; `--frozen-lockfile` makes a lockfile mismatch a build failure rather than a silent re-resolve | ||||||||||||
| 5. **No Go code** - Use Rust instead. | ||||||||||||
| 6. **Python only for SaltStack** - All other Python must be rewritten. | ||||||||||||
| 7. **No Kotlin/Swift for mobile** - Use Tauri 2.0+ or Dioxus. | ||||||||||||
|
|
@@ -164,7 +165,7 @@ Do not "migrate", rewrite, or delete `formal/*.v` as if it were V-lang. | |||||||||||
|
|
||||||||||||
| - **Primary**: Guix (guix.scm) | ||||||||||||
| - **Fallback**: Guix (flake.guix) | ||||||||||||
| - **JS deps**: Deno (deno.json imports) | ||||||||||||
| - **JS deps**: Bun (`package.json` + `bun.lock`). Declare tooling as a devDependency and run `bunx --no-install --bun <tool>` — a bare `bunx <tool>` can fetch an unpinned package and may start Node via its shebang. | ||||||||||||
|
|
||||||||||||
| ### Security Requirements | ||||||||||||
|
|
||||||||||||
|
|
||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use
anbeforenpm-compatible.Change
a npm-compatibletoan npm-compatible.🧰 Tools
🪛 LanguageTool
[misspelling] ~52-~52: Use “a” instead of ‘an’ if the following word doesn’t start with a vowel sound, e.g. ‘a sentence’, ‘a university’.
Context: ...ESM/JS directly — no bundler step. Uses an npm-compatible
package.jsonplus `bun...(EN_A_VS_AN)
[misspelling] ~52-~52: This word is normally spelled as one.
Context: ...lus
bun.lock— both are expected, not anti-patterns. | | Rust | Performance-critical, s...(EN_COMPOUNDS_ANTI_PATTERNS)
🤖 Prompt for AI Agents
Source: Linters/SAST tools