chore(ci): remove the rhodibot rule that could never delete anything - #7
Merged
hyperpolymath merged 2 commits intoSep 19, 2026
Merged
Conversation
The rule deletes ../../../../.github/CONTRIBUTING.md when a nested CONTRIBUTING.md is present. These workflows run from the repository root, so that path resolves outside the repository - the condition is never true and the file is never touched. It has been inert since it was written. Removed, along with the stale mention in each file's header comment. - `actions/validate/.github/workflows/rhodibot.yml` - `bindings/deno/.github/workflows/rhodibot.yml` - `bindings/haskell/.github/workflows/rhodibot.yml` - `bindings/rust/.github/workflows/rhodibot.yml` - `editors/vscode/.github/workflows/rhodibot.yml`
This copy spells the path ../../../ rather than ../../../../ (pandoc sits one level deep, not two), which is still outside the repository when the workflow runs from the root - so it is equally inert.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (7)
🔇 Additional comments (6)
📝 SummarySummary by CodeRabbit
WalkthroughThe Rhodibot workflows no longer delete duplicate parent-directory ChangesRhodibot rule update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the workflow trail Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
hyperpolymath
deleted the
chore/rhodibot-remove-dead-contributing-delete
branch
September 19, 2026 17:37
hyperpolymath
added a commit
that referenced
this pull request
Sep 19, 2026
…low (#9) #7 removed the dead `CONTRIBUTING` delete rule from five of the six nested rhodibot workflows, but in `editors/vscode/…` it changed only the header comment — the rule itself is still there: ```sh if [ -f "editors/vscode/.github/CONTRIBUTING.md" ] && [ -f ".github/CONTRIBUTING.md" ]; then rm editors/vscode/.github/CONTRIBUTING.md ``` `editors/vscode/.github/CONTRIBUTING.md` **exists on `main`** — it is a deliberate nested guide, not a duplicate. Nothing is at risk today (GitHub reads workflows only at the repository root, and this one is nested), but a rule that deletes a real file is not something to leave lying about for whoever moves this workflow up later. This is the same removal #7 made in the other five files, applied to the sixth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rhodibot.ymlcarries a rule that deletes a duplicate guide:It can never fire. These workflows run from the repository root, where
../../../../resolves outside the repository — so the second condition is never true and the file is never a candidate. The rule has been inert the whole time.That mattered when the guide moved to
.github/CONTRIBUTING.md(#5): the obvious reading of this rule is "something will delete that file", and it will not. Removing it so the workflow says what it does.Six copies, one per nested sub-project (
actions/validate,bindings/{deno,haskell,rust},editors/vscode,pandoc) — the stale mention in each file's header comment goes with it.No behaviour change: the condition was already false on every run.