Skip to content

fix(ci): unbreak workflow YAML and add a complete actions.lock - #80

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking
Aug 27, 2026
Merged

fix(ci): unbreak workflow YAML and add a complete actions.lock#80
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Remediates GitHub Workflow Dependency Locking (public preview, no changelog entry), which rejects runs at startup_failure — zero jobs, no logs, nothing in REST or GraphQL. Full analysis: hyperpolymath/standards#657.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead → 0 startup_failure, 13 running.

Five steps, in order — each blocks the next

1. Unbreak the workflow YAML. Any permissions: carrying a scalar with an indented mapping under it:

permissions: read-all
  actions: read        # <- mapping under a scalar. Unparseable.

This reaches past the one file: gh actions-lock refuses to run when any workflow in the repo fails to parse, so the repo can never acquire a lockfile and can never self-heal.

2. Repin standards reusables off commits with no actions.lock. The rejection requires the callee to be covered at the pinned SHA — unsatisfiable at a pre-lockfile commit.

3. Generate the lockfile with gh actions-lock.

4. Hand-add the reusable-caller entries the tool omits, as '<path>': [].

⚠️ Measured across 218 repos: P(startup_failure | has lockfile) = 91.7% vs 15.8% without — because every workflow a lockfile omits is rejected. A partial lock is worse than none. Running gh actions-lock and stopping there is how this outage spread.

5. Restore SPDX-License-Identifier to line 1, which the tool displaces with its own banner and which the workflow-security linter greps via head -1.

Verified before this PR was opened

0 unparseable workflows · lockfile covers every workflow, no omissions · SPDX on line 1 in every file. The script refuses to push if any of the three fails.

🤖 Generated with Claude Code

Remediates GitHub Workflow Dependency Locking (public preview), which
rejects runs at startup_failure with zero jobs and no logs. See
hyperpolymath/standards#657.

Five steps, in order, because each blocks the next:

1. Unbroke any workflow whose `permissions:` carried a scalar with an
   indented mapping under it - blind-permissions-insertion damage. This
   matters beyond the one file: gh actions-lock refuses to run when ANY
   workflow in the repo fails to parse, so the repo could never acquire a
   lockfile and could never self-heal.

2. Repinned hyperpolymath/standards reusables off commits that have no
   actions.lock. The rejection requires the CALLEE to be covered at the
   pinned SHA, which is unsatisfiable at a pre-lockfile commit.

3. Generated the lockfile with gh actions-lock.

4. Hand-added the reusable-workflow caller entries the tool omits, as
   '<path>': []. Measured across 218 repos: P(startup_failure | has
   lockfile) = 91.7% vs 15.8% without, because every workflow a lockfile
   OMITS is rejected. A PARTIAL lock is worse than none - running
   gh actions-lock and stopping there is how this outage spread.

5. Restored SPDX-License-Identifier to line 1, which the tool displaces
   with its own banner and which the workflow-security linter greps with
   head -1.

Verified before push: 0 unparseable workflows, lockfile covers every
workflow with no omissions, SPDX on line 1 in every file.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead -> 0
startup_failure, 13 running.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hyperpolymath
hyperpolymath merged commit 368e7cd into main Aug 27, 2026
20 of 23 checks passed
@hyperpolymath
hyperpolymath deleted the fix/workflow-dependency-locking branch August 27, 2026 03:43
@gitar-bot

gitar-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8079bfd8-93aa-4e71-a512-92ec8df8898f

📥 Commits

Reviewing files that changed from the base of the PR and between 4ccec23 and ad88faa.

⛔ Files ignored due to path filters (1)
  • .github/workflows/actions.lock is excluded by !**/*.lock
📒 Files selected for processing (12)
  • .github/workflows/boj-build.yml
  • .github/workflows/casket-pages.yml
  • .github/workflows/codeql.yml
  • .github/workflows/dogfood-gate.yml
  • .github/workflows/governance.yml
  • .github/workflows/hypatia-scan.yml
  • .github/workflows/mirror.yml
  • .github/workflows/placement-guard.yml
  • .github/workflows/push-email-notify.yml
  • .github/workflows/scorecard.yml
  • .github/workflows/secret-scanner.yml
  • .github/workflows/verify-tlaplus.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated workflow configuration comments and permissions.
    • Refreshed pinned workflow action versions for security and maintenance.
    • Updated the email notification action version.
    • No changes to application functionality or user-facing behaviour.

Walkthrough

The pull request updates GitHub Actions workflow comments, permissions, reusable workflow commit pins, and the mail-sending action version. It does not change workflow job logic.

Changes

Workflow maintenance

Layer / File(s) Summary
Workflow management headers
.github/workflows/boj-build.yml, .github/workflows/casket-pages.yml, .github/workflows/codeql.yml, .github/workflows/dogfood-gate.yml, .github/workflows/placement-guard.yml, .github/workflows/verify-tlaplus.yml
Management comments were added, removed, or duplicated.
Reusable workflow permissions and pins
.github/workflows/governance.yml, .github/workflows/hypatia-scan.yml, .github/workflows/mirror.yml, .github/workflows/scorecard.yml, .github/workflows/secret-scanner.yml
Reusable workflow references were updated to pinned commits. Selected workflows now grant actions: read permission.
Mail action pin
.github/workflows/push-email-notify.yml
The mail-sending action changed from dawidd6/action-send-mail@v18 to dawidd6/action-send-mail@v3.12.0.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit checks the workflow lines,

Pins new commits in neat designs.
Comments hop and permissions read,
A newer mail action moves ahead.
No job logic changed in the run.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Security 1 high

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Codacy results indicate that this pull request is not up to standards. While the PR successfully resolves YAML syntax issues and restores necessary license headers, the 'actions.lock' file mentioned in the PR title and acceptance criteria is missing from the diff. This prevents verification of the primary goal: a complete and manually-augmented lockfile for all actions. Additionally, the workflow for email notifications uses a mutable version tag instead of a commit SHA, which introduces security risks and is inconsistent with the PR's objective of immutable pinning. Finally, a tool-related artifact has introduced duplicate header comments across all modified files.

About this PR

  • The 'actions.lock' file is missing from this PR. Since a complete lockfile is a primary focus of this change (including manual additions for reusable callers), please ensure it is included so it can be verified.
  • Redundant management headers have been introduced across all workflows. A duplicate line ('# This workflow is managed by gh actions-lock.') appears at line 3 in every file and should be removed.

Test suggestions

  • All modified workflows have valid YAML syntax and parse successfully
  • The actions.lock file contains exhaustive coverage of all workflows including manual additions
  • SPDX-License-Identifier is positioned at line 1 of every workflow file
  • Reusable workflow references are updated to specific pinned SHAs
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. The actions.lock file contains exhaustive coverage of all workflows including manual additions

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

steps:
- name: Send push notification email
uses: dawidd6/action-send-mail@v18
uses: dawidd6/action-send-mail@v3.12.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

This third-party action is pinned to a mutable version tag. To ensure supply-chain security and immutability, it should be pinned to a full-length commit SHA. This change is also necessary to maintain consistency with the PR's goal of implementing a comprehensive locking mechanism via 'actions.lock'.

@@ -1,5 +1,6 @@
# SPDX-License-Identifier: MPL-2.0
# This workflow is managed by gh actions-lock.
# This workflow is managed by gh actions-lock.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Nitpick: Duplicate header comment. This line is identical to line 2 and should be removed to keep the workflow header clean. This issue appears consistently across all modified workflow files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant