Repository navigation
Adjust advisory lint job to report warnings without failing its check run - #63
Merged
Merged
Conversation
Co-authored-by: i12bp8 <57963363+i12bp8@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Lint (advisory, non-blocking)
Adjust advisory lint job to report warnings without failing its check run
Sep 17, 2026
i12bp8
marked this pull request as ready for review
September 17, 2026 15:32
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments; the advisory lint behavior is correctly aligned.
Pull request overview
Updates the advisory lint workflow so clang-format findings remain visible without failing the check.
Changes:
- Moves
continue-on-errorto theufbt lintstep. - Aligns the workflow comment with the implementation.
File summaries
| File | Summary |
|---|---|
.github/workflows/build.yml |
Updates advisory lint error handling and documentation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Lint (advisory, non-blocking)Actions job was surfacing clang-format findings as a failed/action-required check outcome instead of an advisory result. This PR updates lint error-handling scope so violations remain visible but do not fail the lint check run.Workflow error-handling scope
continue-on-error: truefrom thelintjob level to theufbt lintstep level in.github/workflows/build.yml.ufbt lintdiagnostics in logs/summary while preventing the advisory lint check from being marked failed.Intent documentation alignment