Skip to content

Adjust advisory lint job to report warnings without failing its check run - #63

Merged
i12bp8 merged 2 commits into
mainfrom
copilot/fix-lint-actions-job
Sep 17, 2026
Merged

i12bp8 merged 2 commits into
mainfrom
copilot/fix-lint-actions-job

Conversation

Copilot AI commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

The Lint (advisory, non-blocking) Actions job was surfacing clang-format findings as a failed/action-required check outcome instead of an advisory result. This PR updates lint error-handling scope so violations remain visible but do not fail the lint check run.

  • Workflow error-handling scope

    • Moved continue-on-error: true from the lint job level to the ufbt lint step level in .github/workflows/build.yml.
    • Keeps ufbt lint diagnostics in logs/summary while preventing the advisory lint check from being marked failed.
  • Intent documentation alignment

    • Updated the inline workflow comment to reflect that non-blocking behavior is implemented at the lint step, not the whole job.
lint:
  name: Lint (advisory, non-blocking)
  runs-on: ubuntu-latest
  steps:
    - name: ufbt lint (clang-format check)
      continue-on-error: true
      uses: flipperdevices/flipperzero-ufbt-action@v0.1
      with:
        app-dir: .
        task: lint

Co-authored-by: i12bp8 <57963363+i12bp8@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Lint (advisory, non-blocking) Adjust advisory lint job to report warnings without failing its check run Sep 17, 2026
Copilot AI requested a review from i12bp8 September 17, 2026 15:29
@i12bp8
i12bp8 marked this pull request as ready for review September 17, 2026 15:32
Copilot AI lite review requested due to automatic review settings September 17, 2026 15:32
@i12bp8
i12bp8 merged commit a906ed3 into main Sep 17, 2026
6 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review comments; the advisory lint behavior is correctly aligned.

Pull request overview

Updates the advisory lint workflow so clang-format findings remain visible without failing the check.

Changes:

  • Moves continue-on-error to the ufbt lint step.
  • Aligns the workflow comment with the implementation.
File summaries
File Summary
.github/workflows/build.yml Updates advisory lint error handling and documentation.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants