Repository navigation
Conversation
tagtinker_targets_load() wrote the PLID into the target and then cleared the whole target with memset() (since 0447f12, custom size support). After a restart every saved tag therefore had PLID 00 00 00 00, the broadcast address: targeted payloads (LED Test, Set Image, Set Text) were ignored by the tag, while broadcast commands such as the diagnostic page still worked. A tag added in the current session was fine until the app was closed. Clear the slot first, then compute the PLID. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QYkmJ3RnCgGZEBKnfRJt5x
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets: keep the PLID computed when loading targets.txt
Problem
Since #62 (custom size, commit 0447f12),
tagtinker_targets_load()computes thePLID into the target slot and then clears the whole slot with
memset().After every restart of the app, all saved tags have PLID
00 00 00 00, thebroadcast address:
Seen on a Pricer F14 (type 1327): the transmit log showed the right barcode
with
PLID 00 00 00 00and frames starting85 00 00 00 00 ....Change
Clear the slot first, then compute the PLID (one line moved).
Tested
Flipper Zero, firmware mntm 12, Pricer F14 type 1327 (208x112 red),
saved tag, app restarted: LED Test, Set Image and Set Text update the tag
again. Frames now carry the tag's PLID.