ENG-1989 Remove sconification API & deployment from iapp - #275
Open
Christophe-iExec wants to merge 24 commits into
Open
ENG-1989 Remove sconification API & deployment from iapp#275Christophe-iExec wants to merge 24 commits into
Christophe-iExec wants to merge 24 commits into
Conversation
- Remove sconify/ and singleFunction/ source directories - Remove WebSocket infrastructure (was exclusively used for sconification) - Remove utils only used by sconification (ethereumAddressZodSchema, parseImagePath, utils/sleep, websocket) - Remove constants.ts (all content was sconification-related) - Simplify index.ts: remove sconify HTTP stubs, WebSocket setup, and related imports - Simplify errors.ts: remove zod ValidationError handling (no longer used) - Remove deployment workflows: reusable-api-deploy.yml, api-deploy-rollback.yml - Remove deploy job from api-deploy-release.yml (kept docker-publish) - Remove ENCLAVE_KEY_PATH and sig/enclave-key.pem from docker-compose.yml - Remove ensure-signing-key npm script - Remove unused dependencies: dockerode, ethers, jwt-decode, zod, zod-validation-error - Remove unused devDependencies: @types/dockerode, @types/ws
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the sconification API and its deployment infrastructure from the iapp project, following the dropping of SGX support and the discovery that the Azure custom self-hosted runners used for deployment are being cleaned up (ENG-1974).
Changes
API source code — deleted
api/src/sconify/sconifyBuild.handler.ts— WebSocketSCONIFY_BUILDrequest handlerapi/src/sconify/sconifyBuild.service.ts— sconification orchestration serviceapi/src/singleFunction/— all 8 Docker operation helpers (checkPushToken,getSconifiedImageFingerprint,inspectImage,pruneBuilderCache,pullPublicImage,pullSconeImage,pushImage,removeContainer,removeImage,sconifyImage)api/src/utils/websocket.ts— WebSocket server (exclusively used for sconification)api/src/utils/ethereumAddressZodSchema.ts— wallet address validator (only used by sconify handler)api/src/utils/parseImagePath.ts— image path parser (only used by sconify service)api/src/utils/utils.ts—sleephelper (only used inwebsocket.ts)api/src/constants/constants.ts— all content was sconification-related (SCONIFY_IMAGE_NAME,SCONIFY_IMAGE_VERSIONS, template configs, WS timing constants)API source code — modified
api/src/index.ts— removed all sconify HTTP stubs (/sconify,/sconify/build), WebSocket setup and related imports; retains health and root endpointsapi/src/utils/errors.ts— removedzod-validation-errorValidationErrorhandling (no longer triggered after removing zod-based request validation)CI/CD workflows — deleted
.github/workflows/reusable-api-deploy.yml— SSH deployment workflow usingAzure_runners(the specific file flagged in ENG-1974).github/workflows/api-deploy-rollback.yml— rollback deployment workflowCI/CD workflows — modified
.github/workflows/api-deploy-release.yml— removed thedeployjob that calledreusable-api-deploy.yml;docker-publishjob is retainedDeployment config — modified
api/docker-compose.yml— removedENCLAVE_KEY_PATHenvironment variable andsig/enclave-key.pemvolume mount (SGX signing key artefacts)Dependencies — modified
api/package.json— removedensure-signing-keynpm script; removed dependencies:dockerode,ethers,jwt-decode,zod,zod-validation-error; removed devDependencies:@types/dockerode,@types/wsapi/package-lock.json— needs to be regenerated: runnpm installinsideapi/and commit the result before merging (the full lock file could not be pushed programmatically due to size constraints)Testing
After applying this PR, verify:
Key: ENG-1989
Co-authored by Claude agent for Jira.