Repository navigation
[Property-grid]: element list rewrite to list - #1830
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
List items lost keyboard activation, and scrolling behavior lacks automated coverage.
2 open findings
What changed in this PR
Adds virtualized rendering to the property-grid element list for improved large-list performance.
Changes:
- Replaces menu items with virtualized iTwinUI list items.
- Adds viewport sizing support for tests.
- Adds the virtualization dependency and release changeset.
| File | Description |
|---|---|
ElementList.tsx |
Implements virtualized list rendering. |
ElementList.scss |
Adds flexible scrolling layout. |
setup.ts |
Mocks element dimensions for tests. |
package.json |
Adds React Virtual dependency. |
pnpm-lock.yaml |
Updates resolved dependencies. |
| Changeset | Records the minor feature release. |
Files not reviewed (1)
- packages/property-grid/pnpm-lock.yaml: Generated file
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
grigasp
reviewed
Oct 9, 2026
MartynasStrazdas
enabled auto-merge (squash)
October 9, 2026 11:32
grigasp
approved these changes
Oct 9, 2026
MartynasStrazdas
disabled auto-merge
October 12, 2026 11:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.