IBX-12489: Removed the hard-coded tab order from the login form - #2072
Merged
Merged
Conversation
albozek
approved these changes
Sep 9, 2026
OstafinL
approved these changes
Sep 9, 2026
dew326
approved these changes
Sep 9, 2026
The positive tabindex values on the two inputs, the submit buttons and the forgot-password link pushed every other control - including the clear and reveal buttons inside the inputs - behind them in the tab sequence, so tabbing from the login field skipped straight to the password field and those buttons were never focused. Document order already matches the intended order.
barbaragr
force-pushed
the
IBX-12489-login-inputs-focus-order
branch
from
September 9, 2026 13:33
a434321 to
9eca71d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The login form hard-coded
tabindex="1"–"4"on the inputs, the forgot-password link and the submit buttons. Positive tabindex values pull those elements ahead of everything else in the tab order and skip the inputs' own action buttons (Clear, Toggle password visibility) entirely. Removed all five, so the form now follows DOM order.For QA:
/login— tab from the top: Username → Clear → Password → Clear → Toggle password visibility → Forgot password → Sign in. Each control shows its focus ring.Documentation: