Adding code generation code - #1711
staudtMarius wants to merge 18 commits into
Conversation
staudtMarius
added
code quality
# Conflicts: # CHANGELOG.md # build.gradle
# Conflicts: # build.gradle
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Had a first glimpse into this. Need to check still the most of the changes but some first aspects from my side.
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * © 2021. TU Dortmund University, | |||
| * © 2026. TU Dortmund University, | |||
There was a problem hiding this comment.
original year should be kept, same for others
There was a problem hiding this comment.
Since th file is newly generated this information is overwritten.
| return QuantityUtils.equals(b, that.b) | ||
| && QuantityUtils.equals(g, that.g) | ||
| && QuantityUtils.equals(r, that.r) | ||
| && QuantityUtils.equals(x, that.x) | ||
| && QuantityUtils.equals(iMax, that.iMax) | ||
| && QuantityUtils.equals(vRated, that.vRated); | ||
| } |
There was a problem hiding this comment.
the way this has been done before is no longer possible?
There was a problem hiding this comment.
With this method we check if two quantities are equivalent to each other. If not false would be returned for 1000 V == 1 kV. Before we explicitly converted the quantites to a specific unit. I wanted to remove this.
There was a problem hiding this comment.
Not sure on this, but aren't there cases where we require the right prefix of the unit (e.g. kV) and thus this can cause problems?
There was a problem hiding this comment.
We only need this in SIMONA and for writing the information to the file. The part in SIMONA is not a problem, because we explicitly convert to the correct unit there. As for writing the model to file, I will add an explicit conversion to prevent possible bugs.
2 participants
Resolves #1710