[FEATURE] Add managed recycler state and lifecycle API #297

Activity

1. ifBars

   added

   enhancementNew feature or requestNew feature or request

   LowVery minor issue, non gameplay hindering, fix all high prio firstVery minor issue, non gameplay hindering, fix all high prio first

   on Aug 29, 2026
2. ifBars commented on Sep 2, 2026

   

   ifBars

   on Sep 2, 2026

   OwnerAuthor

   More actions

   @Diffuin Research this and create an implementation plan

   👀React with 👀1Reacted by diffuin
3. diffuin commented on Sep 2, 2026

   

   diffuinBot

   on Sep 2, 2026

   Last edited by ifBars

   More actions

   Issue investigation

   Confidence: Medium

   The issue is actionable and needs no rewrite. Plan a read-only S1API.Trash.Recycler wrapper and RecyclerRegistry with direct state, hatch, position, and GameObject access, plus registry-level ProcessingStarted and ProcessingStopped events bridged from native UnityEvents. Do not expose SendState, payout, cash, internal UI, or interaction methods until Mono and IL2CPP runtime evidence proves safe native forwarding. Native declarations match, but method bodies and serialized recycler prefabs are unavailable, so event timing, eligibility rules, and late-instantiation behavior require human validation.

   Recommended next steps

   1. Place the API in S1API.Trash as RecyclerState, Recycler, and RecyclerRegistry. Use RecyclerRegistry.GetAll() for an immutable active-object snapshot and cache wrappers by native GetInstanceID within a scene.
   2. Forward State, IsHatchOpen, transform.position, and gameObject directly through the native component. Keep the wrapper sealed, internally constructed, and free of native types, setters, UI, animation, audio, collider, payout, and cash members.
   3. Bridge native onStart and onStop to registry-level Action events using the existing cross-runtime event path. Keep SendState and other mutating entry points private to the wrapper; add an interaction method only after native guard and authority behavior are verified on both runtimes.

   Open questions

   • Does native onStart fire after State becomes Processing, and does onStop fire before or after the final state change? Verify the ordering before documenting event guarantees.
   • Should registration use Start, Awake, or another runtime seam to catch every active and late-instantiated recycler without observing partially initialized UnityEvents?
   • Do HandleInteracted or ButtonInteracted preserve all native player, eligibility, and server-authority checks when called through a managed wrapper? If not proven, omit interaction methods from v1.

   Evidence and validation

   Evidence inspected

   • GitHub issue [FEATURE] Add managed recycler state and lifecycle API #297 defines active-recycler discovery, managed state, hatch state, processing lifecycle events, position/GameObject access, and explicit exclusions for payout, cash, prefabs, UI, animation, audio, colliders, and direct RPC access.
   • The alternate and alternate-beta Recycler declarations are byte-identical. Both expose EState values HatchClosed, HatchOpen, and Processing; State; IsHatchOpen; UnityEvent onStart/onStop; public HandleInteracted, ButtonInteracted, CashInteracted, and SendState; and private Process, SetState, SetHatchOpen, and OnDestroy members.
   • S1API.Casino.CasinoGameRegistry and S1API.Audio.JukeboxManager establish active-scene discovery, immutable snapshots, instance-ID wrapper caching, and scene cleanup. S1API.Trash.TrashContainer establishes the existing Trash namespace and cross-runtime Unity event handling patterns.
   • AssetRipper path search found recycler animation clips and materials but no recycler prefab or scene YAML. Searches found no Recycler references under the stripped persistence sources, so persistence remains unconfirmed rather than an API requirement.

   Validation performed

   • Read the repository AGENTS.md, CONTRIBUTING.md, and CODING_STANDARDS.md instructions.
   • Read the schedule-one-modding, review-issue, and human-writing guidance required for this investigation.
   • Read issue [FEATURE] Add managed recycler state and lifecycle API #297 and its available comments through the read-only GitHub broker.
   • Inspected the existing Casino, Jukebox, TrashContainer, GameLifecycle, and scene-cleanup implementations and tests in the checkout. No repository files were modified; the working tree remains clean. Compared the alternate and alternate-beta Recycler declarations and searched the private AssetRipper corpus for recycler assets and serialized event data.

   Runtime validation remaining

   • No build or unit test was run because this request is investigation and planning only.
   • Run the documented MonoMelon and Il2CppMelon restore, build, and test commands after implementation.
   • Run DocFX, the 80% public API documentation coverage check, and ApiCompat against the exact target branch.
   • Human validation is still required in a live Schedule One environment for native event ordering, processing eligibility, authority behavior, scene reload, stale-wrapper cleanup, and late-instantiated recyclers on both Mono and IL2CPP. Confirm whether recycler state is entirely scene-owned during save/load before documenting that boundary.

   • Create a pull request to implement this plan and close this issue when merged.

   Diffuin run details

   • Provider: codex
   • Model: gpt-5.6-luna
   • Reasoning: xhigh (Luna advisor: complexity (high); baseline coupled source-backed request)
   • Elapsed: 531s
   • Codex thread: 01a06014-a13b-7fb1-b4c0-8e7a03052ef0

   ---

   AI notice: Generated with AI assistance and not guaranteed accurate. Verify findings and plans against the current source and runtime.

   🚀React with 🚀1Reacted by diffuin

   👀React with 👀1Reacted by diffuin
4. diffuin commented on Oct 14, 2026

   

   diffuinBot

   on Oct 14, 2026

   Last edited by diffuin

   More actions

   I opened #363
5. ifBars

   closed this as completedin #363on Oct 15, 2026