Skip to content

fix(npc): restore unlocked supplier conversations after loading #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ifBars merged 1 commit into from
Oct 16, 2026
Merged

fix(npc): restore unlocked supplier conversations after loading #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions S1API/Entities/NPCSupplier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,12 +150,12 @@ internal void EnsureSupplier()
return;
}

// Native suppliers keep a conversation object for persistence and
// networking, but do not add it to Messages until SupplierUnlocked.
npc.EnsureMessageConversationReady(resetDefaults: false);
// Saved unlocks can be restored before Supplier.Start subscribes to OnUnlocked.
// Reconcile the phone entry from that state even when no message history was saved.
npc.SetConversationCategory(
S1Messaging.EConversationCategory.Supplier,
ensureUi: false);
npc.EnsureMessageConversationReady(resetDefaults: false);
ensureUi: npc.Relationship.IsUnlocked);
EnsureDeadDropReadyDispatcher();
}

Expand Down
Loading