Repository navigation
feat: expose mixed effects to custom mixing-output factories - #368
Closed
Lumahex-star wants to merge 1 commit into
Closed
Lumahex-star wants to merge 1 commit into
Lumahex-star wants to merge 1 commit into
Conversation
ProductMixingOutput now carries the resolved effect list as ProductMixingEffect snapshots (Id, Name, Tier, ValueChange, ValueMultiplier) and a CalculateNativeValue(baseValue) helper that prices those effects with the game's own ProductManager calculation. Custom output factories can now match native mix pricing without a hand-maintained table of effect multipliers. The mixing guide's MDMA example added a flat $10 to SourcePrice, which ignored each ingredient's multiplier and compounded on repeated mixes. It now prices from a fixed base via CalculateNativeValue. Additive only: existing ProductMixingOutput members, the legacy internal constructor, and generated-product pricing are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LX6FM1MZXnbvGC5gXufQe
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 5
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Didn't mean to do this yet, sorry bars. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProductMixingOutput now carries the resolved effect list as ProductMixingEffect snapshots (Id, Name, Tier, ValueChange, ValueMultiplier) and a CalculateNativeValue(baseValue) helper that prices those effects with the game's own ProductManager calculation. Custom output factories can now match native mix pricing without a hand-maintained table of effect multipliers.
The mixing guide's MDMA example added a flat $10 to SourcePrice, which ignored each ingredient's multiplier and compounded on repeated mixes. It now prices from a fixed base via CalculateNativeValue.
Additive only: existing ProductMixingOutput members, the legacy internal constructor, and generated-product pricing are unchanged.
Claude-Session: https://claude.ai/code/session_019LX6FM1MZXnbvGC5gXufQe
Linked issue
Contributor checklist
Summary
Compatibility
Validation
Mono
IL2CPP
Runtime evidence
Documentation