[tagliala]

Fix #50

Proxy#all memoized the first result and ignored the params of later calls on the same proxy. #count reused the memo the same way, and #find overwrote it, so a later #all returned the found record.

The memo exists so #each, #count and #respond_to? do not repeat requests. All of them call #all/#count without params, so the memo stays for that case. With params, #all and #count query the server and leave the memoized result untouched. #find no longer stores its result.

Repeated all(page: 2) calls now make a request each time.

Verification: bundle exec rspec (53 examples) and bundle exec rubocop pass. The Appraisals matrix and a real Kaminari/pagy integration were not run. No UI or AI change, so no screenshots.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

A remaining nit finding reports that the new test's setup fails to exercise the populated-memo branch the change introduces, leaving that key behavior untested.

1 open issue

• Test misses count behavior when memoized result already exists · New

What changed in this PR

This PR fixes issue #50, where Proxy#all memoized its first result and then ignored the query params of subsequent calls on the same proxy. Because #count reused that same memo and #find overwrote it, callers could get stale or wrong data (e.g. a later all(page: 2) returning page 1, or an all after find returning the found record). The fix preserves memoization only for the param-less case (used by #each, #count, and #respond_to?), while param-bearing calls query the server without touching or reusing the memo.

Changes:

• Proxy#all now only memoizes @result when no params are given; with params it issues a fresh klass.all each time.
• Proxy#find no longer stores its result into @result, and Proxy#count now merges/forwards params (guarding against non-hash args like :all) instead of always reusing the memo.
• Proxy::Void#all is overridden to keep returning [] without a request, since the base #all would otherwise hit the network when params are supplied.
• Adds a new spec/hawk/model/proxy_spec.rb covering #all, #count, and void behavior.

File	Description
lib/​hawk/​model/​proxy.rb	Scopes #all memoization to the no-params case, stops #find from caching, forwards params in #count with a non-hash guard, and adds a Void#all override to avoid requests.
spec/​hawk/​model/​proxy_spec.rb	New specs for param-aware #all/#count, the #find-then-#all fix, and void proxy behavior.

One test-coverage note was left inline: the #count "params differ from the loaded result" test uses proxy.all(page: 1), which (correctly, per this change) does not populate @result, so the intended "populated memo + differing params" branch isn't actually exercised.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active issues remain, as the memoization fix is well-scoped and backed by new specs covering the param-aware behavior and void-proxy guarantees.

No open issues 🎉

1 resolved since last review

• Test misses count behavior when memoized result already exists

_{Review effort: Balanced}