Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
steps:
- uses: actions/checkout@v7.0.1
- name: Set up Ruby
uses: ruby/setup-ruby@v1.321.0
uses: ruby/setup-ruby@v1.324.0
with:
ruby-version: '4.0'
rubygems: latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
steps:
- uses: actions/checkout@v7.0.1
- name: Set up Ruby
uses: ruby/setup-ruby@v1.321.0
uses: ruby/setup-ruby@v1.324.0
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true
Expand Down
3 changes: 1 addition & 2 deletions lib/sharepoint/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1200,13 +1200,12 @@ def uri_unescape(uri)
end

# TODO: Try to remove `eval` from this method. Otherwise, fix offenses
# rubocop:disable Security/Eval, Style/DocumentDynamicEvalDefinition, Style/EvalWithLocation, Style/PercentLiteralDelimiters
# rubocop:disable-next Security/Eval, Style/DocumentDynamicEvalDefinition, Style/EvalWithLocation, Style/PercentLiteralDelimiters
def string_unescape(s)
s.gsub!(/\\(?:[abfnrtv])/, '') # remove control chars
s.gsub!('"', '\"') # escape double quotes
eval %Q{"#{s}"}
end
# rubocop:enable Security/Eval, Style/DocumentDynamicEvalDefinition, Style/EvalWithLocation, Style/PercentLiteralDelimiters

def utf8_encode(s)
s.force_encoding('UTF-8') unless s.nil?
Expand Down
Loading