Fix Cromwell submit-docker: remove the brace group that truncated the command

[kennedydane]

What does this PR do?

Fixes docker-attribute tasks failing under the Cromwell 92 install (#189) with:

Error parsing generated wdl
WdlParser$SyntaxError: Unrecognized token:
            sbatch

Cromwell does not run submit-docker as a plain shell script. It wraps the string in a
generated draft-2 WDL task as command { ... }, and that lexer ends the command block at the
first closing brace that is not closing one of its own ${...} references. The
|| { echo ...; exit 1; } group after the image-pull lock therefore ended the command early,
and the sbatch \ call further down was parsed as task-level WDL.

Changes, both in ansible/roles/compiled/templates/cromwell_slurm.conf:

• Report a failed pull with if [ $? -ne 0 ]; then ... fi instead of the brace group. Same
  behaviour: message to stderr, exit 1.
• Extend the comment above submit-docker to state the constraint (no bare closing brace
  anywhere in the string, shell comments included) and name the error it causes.

The plain submit block was not affected.

Checklist

• Linters pass locally: cd ansible && uv run yamllint . && uv run ansible-lint
  (ansible-lint reaches Profile 'production' ... passed).
• CI is green on this PR.

Notes for the maintainer

• Not reproduced against a running Cromwell. The cause was confirmed from the Cromwell 92
  source (ConfigWdlNamespace.makeWdlSource and the draft-2 lexer's command rules), and a
  script applying that lexer rule flags the old line and finds nothing in the fixed template;
  bash -n passes on both submit strings. The linters do not cover .conf templates.
• The installed slurm.conf needs re-rendering on the cluster:
  ansible-playbook site.yaml -t cromwell,cromwell92, then submit a task with a docker
  runtime attribute to confirm.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XvF1yXCjHTqxTHuLLtYmPi

[Copilot]

Copilot review overview

🟢 Approval recommended

The focused change preserves failure behavior and removes all bare closing braces from submit-docker.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes Cromwell Docker submissions by avoiding a brace group that prematurely terminates generated WDL.

Changes:

• Replaces brace-group error handling with if/fi.
• Documents the WDL brace constraint.

File	Description
ansible/​roles/​compiled/​templates/​cromwell_slurm.conf	Corrects image-pull failure handling and documents WDL parsing constraints.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.