Repository navigation
Restore sbatch --wait in Cromwell's submit-docker - #195
Merged
Merged
Conversation
A user's docker tasks are failing since the flag was dropped, and they believe blocking submission fixes it. Put `--wait` back, as in the upstream docs example, so the task can be rerun against the rendered config and the cause narrowed down. With `--wait`, sbatch returns the job's exit status, so a job SLURM kills for time or memory fails the task at once rather than leaving Cromwell waiting forever for an rc file. The cost, recorded in a NOTE at the site, is that Cromwell learns no job id until the job ends: abort cannot scancel it and each running docker task holds a backend thread. `exit-code-timeout-seconds` is the non-blocking alternative to evaluate once the user's failure is understood. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L5um94i6XqNc8EfAwJxEeF
MikeCTZA
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--waitback on thesbatchcall in Cromwell'ssubmit-docker, matching the upstream docs example. It was dropped in 7870b01 ("Submit docker tasks asynchronously"); a user's docker tasks have been failing since and they believe this restores working behaviour.--wait, sbatch returns the job's exit status, so a job SLURM kills for time or memory fails the task immediately instead of Cromwell waiting forever for an rc file (the config sets noexit-code-timeout-seconds, socheck-aliveis only run after a server restart).NOTE:at the site: Cromwell learns no job id until the job ends, so abort cannotscancelit and each running docker task holds a backend thread.exit-code-timeout-secondsis the non-blocking alternative to evaluate once the failure is understood.Test plan
ansible-playbook site.yaml -t cromwell,cromwell92stderr.submitin the failing task's execution directory🤖 Generated with Claude Code
https://claude.ai/code/session_01L5um94i6XqNc8EfAwJxEeF