Repository navigation
Include resumed files in transferred list, fixes issue #34 - #35
Open
rohangirishrao wants to merge 4 commits into
Open
rohangirishrao wants to merge 4 commits into
rohangirishrao wants to merge 4 commits into
Conversation
This details the changes made to fix AtxTray and shutdown copy errors.
These are untested, and in our interruption case, the file only returns older
rohangirishrao
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a transfer is resumed after an interruption, RoboCopy reports the partially copied file as
older, notNew File. Theifblock inRsFileProcessed()only handled thenew file, so the resumed file would never be added to the list of transferred files and its size was never recorded.This led to issues with size logging, but also files being moved to
ERRORdue to last file being resumed, leading totransferredFilesbeing empty.Adding
processed.FileClass.ToLower().Equals("older")now also considers resumed transfers.Note: this branch is on top
e280e9bfrom PR #32 - merge that first! The changelog entry for this PR is also here, so merging PR#32 and then this should be fine.