Skip to content

Make interrupted notification optional - #36

Merged
ehrenfeu merged 5 commits into
imcf:develfrom
rohangirishrao:remove-notification
Oct 21, 2026
Merged

ehrenfeu merged 5 commits into
imcf:develfrom
rohangirishrao:remove-notification

Conversation

@rohangirishrao

@rohangirishrao rohangirishrao commented Oct 16, 2026 •

Copy link
Copy Markdown

As interrupted transfers are restarted correctly, the interrupted email notification to the user is mostly irrelevant and can lead to confusions. In the interest of debugging and wanting to keep track of such events, the notification has been parametrized.

Additionally, as mentioned in issue #31, there can be a race where the AD look up for the email address fails because the system is shutting down.

Changed:

  • New config option SendInterruptedNotification (AtxCommon/Serializables/ServiceConfig.cs), default false
  • SendTransferInterruptedMail() in AtxService/Email.cs only sends the mail if this option is enabled, which can be set in the config.common.xml file.

Testing:

  • Tested with default option false and interrupted a transfer by stopping the service in the middle of one. No email.
  • Enabled the notification option, resumed and interrupted again -> the mail was delivered.

I'm not sure this is a breaking change, as the option doesn't need to be set in the config.

@rohangirishrao rohangirishrao added this to the v4.0.0 milestone Oct 16, 2026
@rohangirishrao rohangirishrao linked an issue Oct 16, 2026 that may be closed by this pull request
@ehrenfeu

Copy link
Copy Markdown
Member

Actually I disagree this fixes #31. It only makes sending the respective email optional, if that option is enabled the issue described there will still occur. Also see the related comment there.

☝️Note: this does NOT mean this PR is pointless or wrong! It's just about that it's not a fix for the referenced issue.

@ehrenfeu ehrenfeu changed the title Make interrupted notification optional, fixes issue #31 Make interrupted notification optional Oct 21, 2026
@ehrenfeu
ehrenfeu merged commit d643ca6 into imcf:devel Oct 21, 2026
2 checks passed
@rohangirishrao
rohangirishrao deleted the remove-notification branch October 22, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transfer interrupted email cannot be sent to user

2 participants