Repository navigation
Make interrupted notification optional - #36
Merged
Merged
Conversation
This details the changes made to fix AtxTray and shutdown copy errors.
Member
|
Actually I disagree this fixes #31. It only makes sending the respective email optional, if that option is enabled the issue described there will still occur. Also see the related comment there. ☝️Note: this does NOT mean this PR is pointless or wrong! It's just about that it's not a fix for the referenced issue. |
ehrenfeu
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As interrupted transfers are restarted correctly, the interrupted email notification to the user is mostly irrelevant and can lead to confusions. In the interest of debugging and wanting to keep track of such events, the notification has been parametrized.
Additionally, as mentioned in issue #31, there can be a race where the AD look up for the email address fails because the system is shutting down.
Changed:
SendInterruptedNotification(AtxCommon/Serializables/ServiceConfig.cs), defaultfalseSendTransferInterruptedMail()inAtxService/Email.csonly sends the mail if this option is enabled, which can be set in theconfig.common.xmlfile.Testing:
I'm not sure this is a breaking change, as the option doesn't need to be set in the config.