Repository navigation
transpile: Do not consider Bool an integral type - #2005
Merged
Merged
Conversation
ahomescu
reviewed
Sep 10, 2026
ahomescu
reviewed
Sep 10, 2026
Rua
force-pushed
the
bool-not-integral
branch
2 times, most recently
from
September 10, 2026 09:05
c7bae39 to
283df6d
Compare
Rua
force-pushed
the
bool-not-integral
branch
from
September 22, 2026 09:33
283df6d to
fcd96e4
Compare
Rua
force-pushed
the
bool-not-integral
branch
from
September 22, 2026 09:39
fcd96e4 to
75ceb4e
Compare
ahomescu
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CTypeKind::is_unsigned_integral_typereturnstrueforBool, which is a bit of a footgun and probably not what most code (or coders) expect. So this removes it. I made sure to check that no code elsewhere relies on this includingBooland adjusted it where necessary. Most of the time, it was being used for wrapping arithmetic, which isn't possible on booleans anyway.