Repository navigation
Conversation
This was referenced Nov 3, 2026
Rua
force-pushed
the
union-null-cast-refactor
branch
from
November 4, 2026 21:27
e083b0c to
b3b9858
Compare
Rua
force-pushed
the
union-null-cast-refactor
branch
from
November 6, 2026 11:29
b3b9858 to
2befc11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the need for the
opt_field_idparameter ofmake_cast_full, and for theconvert_cast_to_unionfunction, which more or less duplicated whatconvert_union_literalwas doing. Moving theNullToPointercast removes the need to discard the already-translatedval, and also the need formake_cast_fullto take aWithStmtsvalue.