Skip to content

Compatibility improvements for existing installs - #28

Merged
wardviaene merged 2 commits into
mainfrom
improve/compat-followups
Oct 10, 2026
Merged

wardviaene merged 2 commits into
mainfrom
improve/compat-followups

Conversation

@wardviaene

@wardviaene wardviaene commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #27, keeping existing installs and IdP setups working as they did in the previous release:

  • SSO user creation: new OIDC/SAML users are created regardless of the license count, as in previous releases.
  • email_verified=false: no longer blocks OIDC logins (e.g. Keycloak or Auth0 users without a verified email). It is only checked when the login would link to an existing user that doesn't use OIDC yet.
  • SAML ↔ OIDC: users can switch between SAML and OIDC logins again (e.g. when moving to another IdP).
  • Google issuer: accounts.google.com is accepted (Google documents both forms).
  • OIDC token renewal: entries without a refresh token are skipped instead of counting as failures, and the retry counter is reset after a successful renewal.
  • SCIM after restart: the saved SCIM token is passed to the SCIM client at startup. Before, SCIM requests returned 401 after a restart or upgrade until the token was regenerated.
  • ReadDir: skips temporary files left behind by an interrupted WriteFile.

Tests:

  • New: TestExternalUserNotBlockedByLicense, TestExternalUserLinking (rewritten), TestWorkerSkipsRenewalWithoutRefreshToken, TestRenewalResetsRetriesOnSuccess, TestReadDirSkipsTempFiles, TestSCIMTokenKeptAfterRestart.
  • Extended: the issuer and email_verified cases in TestUpdateOAuth2DataWithTokenValidatesClaims.
  • go test -race ./... passes.

🤖 Generated with Claude Code

wardviaene and others added 2 commits October 10, 2026 14:11
- New SSO users are created regardless of the license count, as before
- email_verified=false no longer blocks OIDC logins; it is only checked
  when the login links to a user that doesn't use OIDC yet
- Users can switch between SAML and OIDC logins again
- Accept accounts.google.com as Google issuer
- OIDC token renewal skips entries without refresh token and resets the
  retry counter after a successful renewal
- ReadDir skips temporary files of an interrupted WriteFile

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The SCIM client created at startup didn't get the token from the saved
config, so SCIM requests returned 401 after a restart or upgrade until
the token was regenerated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wardviaene
wardviaene merged commit 0868da6 into main Oct 10, 2026
4 checks passed
@wardviaene
wardviaene deleted the improve/compat-followups branch October 10, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant