Repository navigation
Conversation
load_setup_py_data() executes setup.py in the conda-build process. setup.py prepends "." to sys.path, so the source tree's unbuilt zstandard package later shadows the zstandard bindings that conda-package-handling imports for .conda support. conda-build then fails with "Didn't recognize extension for file '...conda'". Read the version from c-ext/python-zstandard.h with load_file_regex() instead.
cibuildwheel installs the test-groups packages unlocked, so it picked up the latest mypy, which now depends on ast-serialize. ast-serialize has no wheels for musllinux_1_1 or musllinux s390x, and building it from source needs a Rust toolchain the containers don't have, failing those wheel jobs before any test ran. Move the test suite's dependencies into a new "test" dependency group, have "dev" include it plus mypy, and point cibuildwheel at "test".
On Apple Silicon runners Homebrew installs into /opt/homebrew, which isn't on the compiler's default search paths, so the --system-zstd build failed with "'zdict.h' file not found". Pass Homebrew's include and lib directories explicitly, and build for arm64 only since Homebrew's libzstd is not universal2.
test_stream_source_readinto intermittently fails on macos-26-intel runners with DeadlineExceeded: a single example took 31s against the 20s deadline, then 18s on hypothesis's rerun, which hypothesis reports as a FlakyFailure. The timing depends on runner load, not on the code under test, so don't enforce a deadline in the ci profile, as the expensive profile already does.
This was referenced Oct 12, 2026
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several workflows have been failing on
mainfor weeks, for reasons unrelated to the code. Each commit fixes one of them:load_setup_py_data()runssetup.pyinside the conda-build process.setup.pyprepends.tosys.path, so the source tree's unbuiltzstandardpackage shadows the zstandard bindings that conda-package-handling needs for.condasupport, and conda-build fails withDidn't recognize extension for file '...conda'. The recipe now reads the version fromc-ext/python-zstandard.hwithload_file_regex().test-groupspackages unlocked, which picked up the latest mypy and its newast-serializedependency. That package has no wheels for those platforms and needs Rust to build. The test suite's dependencies move to a newtestdependency group (whichdevincludes, plus mypy), and cibuildwheel usestest./opt/homebrewon Apple Silicon runners, which isn't on the compiler's search paths ('zdict.h' file not found). The job now passes Homebrew's include/lib dirs and builds arm64 only, since Homebrew's libzstd isn't universal2.test_stream_source_readintohit hypothesis's 20s deadline (31s, then 18s on rerun ->FlakyFailure). Thecihypothesis profile now disables deadlines, as theexpensiveprofile already does.All workflows pass on the fork with these changes: https://github.com/zydo/python-zstandard/actions?query=branch%3Aci-fixes