Repository navigation
Document the button component on Android - #5
Merged
Merged
Conversation
Adds the Kotlin half to the Button page — source embedded from the registry like the other two, registration, and a recording from an emulator. Also records that Android ignores the contract's side: toolbar menu items always sit at the end of the bar.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
The first take was sped up 2.4x to hide dead air, which compressed the first two increments into a blink and read as though the middle had been cut out. screenrecord loads the emulator enough that the counter renders about five seconds behind the tap, so this take spaces the taps three seconds apart, drops the lead-in, and runs near real time.
Synthetic taps from adb are not drawn by show_touches, so the counter appeared to move on its own. This take is tapped by hand: the touch indicator lands on the button and the count follows it, 1 through 6, at real speed with no editing.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Kotlin half to the Button page: source embedded from the registry like the other two, registration snippet, and a recording from an emulator.
Also bumps the registry submodule to pick up the rewritten
ButtonComponent.kt, and notes that Android ignores the contract'sside— toolbar menu items always sit at the end of the bar.The recording is sped up ~2.4×: on the emulator the page takes about seven seconds to load and the counter trails each tap by a second or two, which made real time mostly dead air.