🔒 refactor(di): prevent direct scope replacement on propagated logical scopes - #137
Merged
Merged
Conversation
…l scopes - Update `.gitattributes` to ignore various development and build files for exports 📦 - Update documentation configurations and indices to exclude plans and mark runtime alignment as orphan 📝 - Refactor `ExecutionScopeStore::setScope` to reject scope replacement when a logical scope is already propagated ♻️ - Add a test case to verify that direct scope replacement is rejected after logical scope propagation starts ✅ Refs: #intermix-10.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitattributesto ignore various development and build files for exports 📦ExecutionScopeStore::setScopeto reject scope replacement when a logical scope is already propagated ♻️Change
Type
Behavior and Compatibility
Validation
composer ic:ciFocused validation
composer ic:test:syntaxcomposer ic:test:codecomposer ic:test:lintcomposer ic:test:sniffcomposer ic:test:duplicatescomposer ic:test:probecomposer ic:test:commentscomposer ic:test:architecturecomposer ic:test:staticcomposer ic:test:securitycomposer ic:test:refactorPerformance
composer ic:benchmarkcomposer ic:bench:quickcomposer ic:bench:chartImplementation Notes
Review Focus
Checklist
CONTRIBUTING.mdand the engineering principles.