Repository navigation
Conversation
The at-rest migration re-encrypted any enc:v1 value it couldn't decrypt. A process started with the wrong master key (restored or swapped master.key, different HOME, key-store bug) re-wrapped every stored secret under that key, so restoring the right key later couldn't recover them. Values that don't decrypt are now left byte-identical. The count is reported: a warning when the server starts, secretStorage.undecryptable in /health, and a line in capa status. Only plaintext is migrated. Closes #305
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The at-rest migration re-encrypted any
enc:v1:value it couldn't decrypt, on every database open. A process that ever started with the wrong master key (restored or swappedmaster.key, a differentHOME, a key-store bug) re-wrapped every stored secret under that key. After that, restoring the right key no longer recovered them. Closes #305.Stack 1/5: base develop, next #316. Merge top-down: #319 into #318, ... #316 into #315, then #315 into develop.
What changed
canonicalizeStoredSecretonly encrypts plaintext. Ciphertext that doesn't decrypt is left byte-identical and flagged.migrateSecretsAtRestreturns how many stored secrets are undecryptable, and the database exposes it asundecryptableSecrets.secretStorage.undecryptablein/health;capa status.Test plan
bunx tsc --noEmitChecklist
bunx tsc --noEmitpasses🤖 Generated with Claude Code