build: restore go 1.26.0 + toolchain go1.27.0 directive - #6
Merged
Conversation
dalgo v0.74.0 declared `go 1.27.0` incidentally (a go get run on a 1.27 machine; its real floor was 1.24.0). dalgo v0.74.1 fixed that upstream and declares the founder's convention (go 1.26.0 + toolchain go1.27.0) itself, so this repo's own directive - bumped to 1.27.0 by the previous dalgo v0.74.0 bump (#5) - can now be restored without go mod tidy fighting it. Bumped github.com/dal-go/dalgo v0.74.0 -> v0.74.1 (dal-go/record unchanged at v0.1.3, it did not move). Verified go mod tidy, run AFTER restoring the directive, leaves it at go 1.26.0 + toolchain go1.27.0 (does not rewrite it back to 1.27.0 the way it would have against v0.74.0). GOTOOLCHAIN=go1.26.0 go build ./... && go vet ./... && go test ./... all green; gofmt clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KFsyYhYi9h9Am1JbAMxuhv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dalgo v0.74.0 declared
go 1.27.0incidentally (ago getrun on a 1.27 machine; its real floor is 1.24.0). This is now fixed upstream: dalgo v0.74.1 declares the founder's convention (go 1.26.0+toolchain go1.27.0) itself, which is what let this repo's own directive get restored — it had been pushed togo 1.27.0as a mechanical side effect of the v0.74.0 bump in #5, sincego mod tidywould otherwise fight any lower directive while resolving dalgo v0.74.0.github.com/dal-go/dalgov0.74.0 -> v0.74.1.dal-go/recordunchanged at v0.1.3 (did not move).go 1.26.0+toolchain go1.27.0.Acceptance
go mod tidy, run AFTER setting the directive, leaves it unchanged:GOTOOLCHAIN=go1.26.0 go build ./...succeeds, plusgofmt -l .clean,go vet ./...clean,go test ./...:🤖 Generated with Claude Code
https://claude.ai/code/session_01KFsyYhYi9h9Am1JbAMxuhv