feat: expose element creation context to tree adapters - #1842
Merged
Merged
Conversation
43081j
reviewed
Sep 2, 2026
Expose the intended parent, form element pointer, and template-stack state after a tree adapter creates an element and before the parser inserts it. DOM-backed adapters need this state to establish parser-created form owners as required by the HTML parser. Compute each insertion location once so the callback context and the subsequent insertion use the same target. Co-authored-by: codex <codex@openai.com>
domenic
force-pushed
the
codex/element-creation-hook
branch
from
September 2, 2026 09:28
68482df to
fbd6408
Compare
Contributor
Author
|
Gentle ping! I would love to improve jsdom's form-association machinery based on this. |
Collaborator
|
This looks good, I'm just away this week at ZurichJS. I'll give it another review when I'm back and aim to merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional onElementCreated tree-adapter callback that runs after element creation and before insertion, exposing the intended parent, form element pointer, and template-stack state. jsdom needs these parser-only values to implement step 15 of “create an element for the token”, which establishes parser-created form owners, without subclassing the internal Parser class.
The parser computes each insertion location once so the callback context and subsequent insertion use the same target.